Skip to content

refactor(memory): rename memory2 package to memory - #3413

Open
spomichter wants to merge 2 commits into
mainfrom
chore/rename-memory2-to-memory
Open

refactor(memory): rename memory2 package to memory#3413
spomichter wants to merge 2 commits into
mainfrom
chore/rename-memory2-to-memory

Conversation

@spomichter

Copy link
Copy Markdown
Contributor

memory2 was a transitional name while the original dimos/memory package was being replaced. That package is gone — nothing is tracked under dimos/memory on main — so the 2 no longer distinguishes anything.

Pure rename, no behavior change:

  • dimos/memory2/dimos/memory/ (81 files, git mv so history follows)
  • dimos.memory2.*dimos.memory.* across 151 files (imports, docstrings, docs, CLI help text)
  • Memory2ReplayAdapterMemoryReplayAdapter (dimos/utils/testing/replay.py; the TimedSensorReplay alias is unchanged)
  • all_blueprints.py regenerated — 3 module paths (memory-module, recorder, semantic-search); blueprint/module keys are unchanged, they never carried the 2
  • .gitignore comment

No on-disk format, database, or public API surface changes. Existing recordings open exactly as before.

Verification

  • pytest --numprocesses=logical -m 'not (self_hosted or mujoco or self_hosted_large or web_browser)' (CI's exact invocation) → 3956 passed, 34 skipped, plus 4 failures in test_reactive, b1/test_connection, test_replay_bench[zenoh], and e2e_tests/test_control_coordinator — none of those files are touched by this change or reference memory, and all 4 pass on re-run in isolation (parallel-worker contention + a small local net.core.rmem_default).
  • pytest dimos/memory → 456 passed
  • mypy in a --only-group lint env → byte-identical output to a clean origin/main baseline (same 2 pre-existing stubs/ errors, same 958 files checked)

The memory2 name was transitional — the original dimos/memory package is
long gone (nothing tracked under that path), so the 2 no longer distinguishes
anything. Renames the package, the Memory2ReplayAdapter shim class, and all
prose references.

Pure rename: no behavior, API surface, or on-disk format changes.
@mintlify

mintlify Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
dimensional 🟢 Ready View Preview Aug 9, 2026, 7:51 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@greptile-apps

greptile-apps Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review (151 files, 100 file limit).

Bypass the limit by tagging @greptile-apps to review.

@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
4067 1 4066 211
View the top 1 failed test(s) by shortest run time
::dimos.navigation.nav_3d.evaluator.test_nav_eval
Stack Traces | 0s run time
ImportError while importing test module '.../nav_3d/evaluator/test_nav_eval.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
.../nav_3d/evaluator/test_nav_eval.py:26: in <module>
    from dimos.memory2.store.sqlite import SqliteStore
E   ModuleNotFoundError: No module named 'dimos.memory2'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

…paths

Stream registries store fully-qualified class names, so every database
written before the rename references dimos.memory2.*. Remap the prefix on
read — the classes are otherwise unchanged.
@spomichter
spomichter force-pushed the chore/rename-memory2-to-memory branch from df8c04e to f1b7e2c Compare August 9, 2026 18:03
@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Aug 9, 2026
@spomichter
spomichter force-pushed the chore/rename-memory2-to-memory branch from 361795e to f1b7e2c Compare August 11, 2026 23:25
@paul-nechifor

Copy link
Copy Markdown
Contributor

@spomichter There are some CI failures (linting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants